feat: add shell completion installation - #3
Merged
Merged
Conversation
Install Bash, Zsh, and Fish completion hooks while preserving existing shell configuration. Add a Cargo installation wrapper and path completion hints. Document setup in both READMEs and cover completion behavior with shell integration tests in CI.
Prepend the fixture binary directory to PATH so Fish autoloads completion in clean CI environments. Verify executable resolution and include stderr in completion failures.
Use compinit -i to skip insecure completion directories while retaining permission checks. Guard registration on compdef availability and test safe and insecure directories without a terminal. Run GitHub Actions only for pull requests.
Use FileTrail: for generated commit messages and represent Home paths with an expandable, quoted HOME variable in completion hooks and installation output. Test path quoting and Home relocation, update both READMEs, and simplify the architecture guidance in AGENTS.md.
Wait for inherited writable descriptors to close before executing copied binaries. Use a fixed Cargo test script and cover concurrent fixture creation and execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Bash, Zsh, and Fish completion hooks while preserving existing shell configuration. Add a Cargo installation wrapper and path completion hints.
Document setup in both READMEs and cover completion behavior with shell integration tests in CI.